Glasgow | Jan-26 | Elisabeth Matulian | Sprint 3 | Refactoring Dead Code#1008
Closed
Elisabeth-Matulian wants to merge 2 commits intoCodeYourFuture:mainfrom
Closed
Glasgow | Jan-26 | Elisabeth Matulian | Sprint 3 | Refactoring Dead Code#1008Elisabeth-Matulian wants to merge 2 commits intoCodeYourFuture:mainfrom
Elisabeth-Matulian wants to merge 2 commits intoCodeYourFuture:mainfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Elisabeth-Matulian
added
the
Needs Review
github-actions
Bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
LonMcGregor
changed the title
Elisabeth-Matulian
added
the
Needs Review
hkavalikas
added
Review in progress
hkavalikas
suggested changes
Mar 1, 2026
| const greetingStr = greeting + ", " + name + "!"; | ||
| return `${greeting}, ${name}!`; | ||
| console.log(greetingStr); | ||
| //console.log(greetingStr); |
There was a problem hiding this comment.
You are right to highlight this one, but commenting out is not quite the same as deleting; let's address it.
|
|
||
| const pets = ["parrot", "hamster", "horse", "dog", "hamster", "cat", "hamster"]; | ||
| const capitalisedPets = pets.map((pet) => pet.toUpperCase()); | ||
| //const capitalisedPets = pets.map((pet) => pet.toUpperCase()); |
There was a problem hiding this comment.
You are right to highlight this one, but commenting out is not quite the same as deleting; let's address it.
There was a problem hiding this comment.
You have correctly identified a line that should be removed, but you are missing one more.
There was a problem hiding this comment.
You have correctly identified a line that should be removed, but you are missing one more. Can you see any properties or functions that aren't contributing to your console result of console.log(countedPetsStartingWithH); ?
hkavalikas
added
Reviewed
Elisabeth-Matulian
added
the
Needs Review
hkavalikas
added
Review in progress
|
Awesome job |
hkavalikas
added
Complete
hkavalikas
approved these changes
Mar 2, 2026
Member
|
Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
Completed dead-code
Questions
N/Q